New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed replaced_task_nesting #8500
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #8500 +/- ##
=======================================
Coverage 87.44% 87.44%
=======================================
Files 148 148
Lines 18491 18491
Branches 3156 3156
=======================================
Hits 16169 16169
Misses 2033 2033
Partials 289 289
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@Nusnus it will be great if you can edit the description section later in the PR to add some detail and context, it would be great for others and people like me O:) It is just a request |
I rushed the PR to get to the next one #8501 so I apologize for the lack of context @auvipy - thanks for noticing and sure I'll add it later np ! |
The
replaced_task_nesting
(docs @New in version 5.2.
) was missing from therequest
because it wasn't parsed correctly over the call stack. This made the whole feature invalid as you always lost thereplaced_task_nesting
value which made it reset to zero.This PR fixes the handling of
replaced_task_nesting
and also adds integration tests for the feature that didn't exist before.