Added support for replaced_task_nesting in chains #8501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8501 +/- ##
==========================================
+ Coverage 87.44% 87.45% +0.01%
==========================================
Files 148 148
Lines 18491 18496 +5
Branches 3156 3158 +2
==========================================
+ Hits 16169 16176 +7
+ Misses 2033 2032 -1
+ Partials 289 288 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
thedrow
approved these changes
Sep 13, 2023
auvipy
requested changes
Sep 14, 2023
|
Added message to PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support to replaced_task_nesting in chains allows for overcoming a very specific use case.
Overall, what it does is set all of the tasks of the chain with the correct replaced_task_nesting level, if the canvas is built from a chain that contains a replaced task that is also a chain (in which case the DAG gets broken as two tasks can be each other's parents which this fix allows overcoming).
TODO:
Maybe add some example doc with enhanced explanation although it would require a bit of effort so I'll get to it at a later date.