-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Celery Docker Upgrades #8531
Celery Docker Upgrades #8531
Conversation
… tests via the docker compose broker and backend containers
…cker-unit-tests (partially supported), docker-bash
5026d94
to
e2a814e
Compare
e2a814e
to
08fc734
Compare
Updated PR message @auvipy . |
The integration tests are partially working in the docker environment so this PR doesn't fix 100% per-say the problem from #8447, but it should at least improve on the current capability, allowing the integration tests to even work with the broker and backend from the docker compose (which was 100% broken before - see changes in tox.ini). |
08fc734
to
9f331ce
Compare
Changed a string from '' to "" to trigger full CI to make sure this change doesn't create unwanted side effects. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #8531 +/- ##
=======================================
Coverage 87.45% 87.45%
=======================================
Files 148 148
Lines 18499 18499
Branches 3158 3158
=======================================
Hits 16179 16179
Misses 2032 2032
Partials 288 288
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* Added -docker environment to tox envlist to allow running integration tests via the docker compose broker and backend containers * Set default python for celery docker container to 3.11 from 3.8 * Added make commands: docker-build, docker-lint, docker-unit-tests, docker-unit-tests (partially supported), docker-bash * Added new Docker CI Workflow to validate the docker image is built correctly * No-op code change to trigger full CI
make
commands.For example running
make docker-lint
from thecelery
repo root:The
make help
is also modified: