Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable api, grpc and grpc-web by default in app.toml #2758

Closed
4 tasks
mindstyle85 opened this issue Oct 24, 2023 · 1 comment · Fixed by #2761
Closed
4 tasks

disable api, grpc and grpc-web by default in app.toml #2758

mindstyle85 opened this issue Oct 24, 2023 · 1 comment · Fixed by #2761
Assignees
@rootulp
Labels
enhancement New feature or request

Comments

@mindstyle85
Copy link

Summary

disable api, grpc and grpc-web by default in app.toml

Problem Definition

n/a

Proposal

disable api, grpc and grpc-web by default in app.toml

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@mindstyle85 mindstyle85 added the enhancement New feature or request label Oct 24, 2023
@rootulp rootulp self-assigned this Oct 24, 2023
@rootulp rootulp mentioned this issue Oct 24, 2023
Merged
@rootulp
Copy link
Collaborator

rootulp commented Oct 24, 2023

@mindstyle85 can you provide more details for why they should be disabled by default?

evan-forbes pushed a commit that referenced this issue Oct 25, 2023
@rootulp
chore: disable API, GRPC, and GRPC web by default (#2761)
b786b08 
Closes #2758

## Testing
```
./scripts/single-node.sh
cat ~/.celestia-app/config/app.toml
```

Verified that 

```toml
[api]

# Enable defines if the API server should be enabled.
enable = false
```

```toml
[grpc]

# Enable defines if the gRPC server should be enabled.
enable = false
```

```toml
[grpc-web]

# GRPCWebEnable defines if the gRPC-web should be enabled.
# NOTE: gRPC must also be enabled, otherwise, this configuration is a no-op.
enable = false
```
mergify bot pushed a commit that referenced this issue Oct 25, 2023
@rootulp @mergify
chore: disable API, GRPC, and GRPC web by default (#2761)
bf9179d 
Closes #2758

## Testing
```
./scripts/single-node.sh
cat ~/.celestia-app/config/app.toml
```

Verified that

```toml
[api]

# Enable defines if the API server should be enabled.
enable = false
```

```toml
[grpc]

# Enable defines if the gRPC server should be enabled.
enable = false
```

```toml
[grpc-web]

# GRPCWebEnable defines if the gRPC-web should be enabled.
# NOTE: gRPC must also be enabled, otherwise, this configuration is a no-op.
enable = false
```

(cherry picked from commit b786b08)
evan-forbes pushed a commit that referenced this issue Oct 25, 2023
@rootulp @evan-forbes
chore: disable API, GRPC, and GRPC web by default (#2761)
ada7750 
Closes #2758

## Testing
```
./scripts/single-node.sh
cat ~/.celestia-app/config/app.toml
```

Verified that

```toml
[api]

# Enable defines if the API server should be enabled.
enable = false
```

```toml
[grpc]

# Enable defines if the gRPC server should be enabled.
enable = false
```

```toml
[grpc-web]

# GRPCWebEnable defines if the gRPC-web should be enabled.
# NOTE: gRPC must also be enabled, otherwise, this configuration is a no-op.
enable = false
```

(cherry picked from commit b786b08)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: disable API, GRPC, and GRPC web by default rootulp/celestia-app
2 participants
@rootulp @mindstyle85