chore: disable API, GRPC, and GRPC web by default #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
added
the
backport:v1.x
rach-id
reviewed
Oct 24, 2023
|
Great question. I think it was motivated by this Slack thread. |
rach-id
approved these changes
Oct 25, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
Closes #2758 ## Testing ``` ./scripts/single-node.sh cat ~/.celestia-app/config/app.toml ``` Verified that ```toml [api] # Enable defines if the API server should be enabled. enable = false ``` ```toml [grpc] # Enable defines if the gRPC server should be enabled. enable = false ``` ```toml [grpc-web] # GRPCWebEnable defines if the gRPC-web should be enabled. # NOTE: gRPC must also be enabled, otherwise, this configuration is a no-op. enable = false ``` (cherry picked from commit b786b08)
evan-forbes
pushed a commit
that referenced
this pull request
Oct 25, 2023
Closes #2758 ## Testing ``` ./scripts/single-node.sh cat ~/.celestia-app/config/app.toml ``` Verified that ```toml [api] # Enable defines if the API server should be enabled. enable = false ``` ```toml [grpc] # Enable defines if the gRPC server should be enabled. enable = false ``` ```toml [grpc-web] # GRPCWebEnable defines if the gRPC-web should be enabled. # NOTE: gRPC must also be enabled, otherwise, this configuration is a no-op. enable = false ``` (cherry picked from commit b786b08)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2758
Testing
Verified that