Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a custom query route for tendermint to use to create transaction inclusion proofs #698

Closed
3 tasks done
Tracked by #514
evan-forbes opened this issue Sep 12, 2022 · 0 comments · Fixed by #708
Closed
3 tasks done
Tracked by #514

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Sep 12, 2022

Currently, when creating a tx inclusion proof in celestia-core, we have to encode a portion of the block data into rows. This is necessary to create the nmt tree(s) used to create the proof(s). It's problematic not only because we don't want to have any application logic in core, but in order to fully test that code we have to have a lot of other application specific logic (malleated txs, non-interactive defaults/other square layout rules).

To fix this, we'd like to move all share encoding logic to the app, but this means we can't do tx inclusion proofs in core like normal tendermint. We can get around this by creating a custom query route, and calling that route each time we want to create a tx inclusion proof in tendermint.

This will involve:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant