Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherry-pick common Docker CI to v0.13.x #1699

Merged
merged 2 commits into from
May 4, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented May 4, 2023

Motivation

rollkit/local-celestia-devnet#28 (comment) and rollkit/local-celestia-devnet#28 (comment)

Description

Cherry pick 7380eec to the v0.13.x release branch. I will cut v0.13.1 after this merges.

## Overview

Helloo team!

This PR uses the common CI pipeline for building the Docker containers
and tagging them.

🚨 ~~First, we have to wait to merge the
[PR-29](celestiaorg/.github#29), because we need
the file available in the right path.~~

---

## Checklist

- [x] Merge [PR-29](celestiaorg/.github#29).
- [x] Need to be tested before merging this one.
- [x] Linked issues closed with keywords

---
@rootulp rootulp requested a review from tty47 May 4, 2023 13:21
@rootulp rootulp requested a review from evan-forbes as a code owner May 4, 2023 13:21
@rootulp rootulp self-assigned this May 4, 2023
@MSevey MSevey requested review from a team and rach-id and removed request for a team May 4, 2023 13:21
@rootulp rootulp added the itn label May 4, 2023
tty47
tty47 previously approved these changes May 4, 2023
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rootulp rootulp requested a review from tty47 May 4, 2023 13:30
@MSevey MSevey requested a review from a team May 4, 2023 13:30
@rootulp rootulp merged commit 153cd1a into celestiaorg:v0.13.x May 4, 2023
@rootulp rootulp deleted the rp/cherry-pick-common-docker branch May 4, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants