Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QGB Verify the sent data commitment confirm is a data commitment attestation request #524

Merged
merged 1 commit into from
Jul 13, 2022
Merged

QGB Verify the sent data commitment confirm is a data commitment attestation request #524

merged 1 commit into from
Jul 13, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Jul 5, 2022

Closes #520

@rach-id rach-id added the C: QGB label Jul 5, 2022
@rach-id rach-id self-assigned this Jul 5, 2022
@rach-id
Copy link
Member Author

rach-id commented Jul 5, 2022

Depends on #523

@rach-id rach-id marked this pull request as draft July 5, 2022 15:32
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022 •
edited
Loading

Codecov Report

Merging #524 (53e6ab0) into qgb-integration (0ed87bb) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@                 Coverage Diff                 @@
##           qgb-integration     #524      +/-   ##
===================================================
- Coverage            12.51%   12.47%   -0.04%     
===================================================
  Files                   56       56              
  Lines                 9679     9704      +25     
===================================================
  Hits                  1211     1211              
- Misses                8385     8410      +25     
  Partials                83       83
Impacted Files Coverage Δ
x/qgb/keeper/msg_server.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed87bb...53e6ab0. Read the comment docs.

@rach-id rach-id mentioned this pull request Jul 6, 2022
Merged
@rach-id rach-id force-pushed the verify_confirm_is_a_dc_att branch from 089dfe4 to 53e6ab0 Compare July 13, 2022 00:49
@rach-id rach-id requested a review from evan-forbes July 13, 2022 00:51
@rach-id rach-id marked this pull request as ready for review July 13, 2022 00:51
evan-forbes
evan-forbes approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 dope

@rach-id rach-id merged commit a246519 into celestiaorg:qgb-integration Jul 13, 2022
@rach-id rach-id deleted the verify_confirm_is_a_dc_att branch July 13, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@rach-id rach-id

Labels
None yet
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rach-id @codecov-commenter @evan-forbes