QGB Orchestrator only signs if part of valset #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
depends on #519 |
This was
linked to
issues
Jul 5, 2022
Codecov Report
@@ Coverage Diff @@
## qgb-integration #523 +/- ##
===================================================
+ Coverage 11.72% 12.52% +0.79%
===================================================
Files 65 56 -9
Lines 10881 9680 -1201
===================================================
- Hits 1276 1212 -64
+ Misses 9515 8385 -1130
+ Partials 90 83 -7
Continue to review full report at Codecov.
|
rach-id
force-pushed
the
orch_only_sign_if_part_of_valset
branch
from
06c0d95
to
e0a388e
Compare
# Conflicts: # e2e/qgb/orchestrator_test.go # e2e/qgb/qgb_network.go # x/qgb/orchestrator/orchestrator.go
evan-forbes
approved these changes
Jul 12, 2022
x/qgb/keeper/msg_server.go
Outdated
| var previousValset *types.Valset | ||
| // TODO add test for case nonce == 1. | ||
| if msg.Nonce == 1 { | ||
| // if the msg.Nonce == 1, the current valset should sign the first valset |
There was a problem hiding this comment.
we might want to add to this comment as to why we do this.
rach-id
commented
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #406 #480