Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease the default peer gossip sleep duration #784

Closed
evan-forbes opened this issue Jun 8, 2022 · 0 comments · Fixed by #785
Closed

Decrease the default peer gossip sleep duration #784

evan-forbes opened this issue Jun 8, 2022 · 0 comments · Fixed by #785
Assignees
@evan-forbes

Comments

@evan-forbes
Copy link
Member

tendermint/tendermint#8651 introduced a restructuring a the peer catchup sleep mechanism. In order for this fix to work as intended, the peer gossip sleep duration needs to be decreased. If a too high value is chosen, then nodes will timeout and start new rounds for large proposal blocks, as the data cannot be gossiped quick enough.

We should decrease the default peer gossip sleep duration from 100ms to 2ms.
@evan-forbes evan-forbes self-assigned this Jun 8, 2022
@evan-forbes evan-forbes mentioned this issue Jun 8, 2022
Merged
cmwaters pushed a commit that referenced this issue Sep 20, 2023
@mergify @sergio-mena
Struct Client exposes sensitive data (#784) (#788)
49cf700 
(cherry picked from commit ecd5ee112533cda28900cbd75afb349f67da3fa5)

Co-authored-by: Sergio Mena <sergio@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evan-forbes evan-forbes

Labels
None yet
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

decrease default peer gossip sleep duration celestiaorg/celestia-core
1 participant
@evan-forbes