Skip to content

Commit

Permalink
chore(ci): remove 'continue-on-error' configuration from flakey tests (
Browse files Browse the repository at this point in the history
…#2913)

<!--
Thank you for submitting a pull request!

Please make sure you have reviewed our contributors guide before
submitting your
first PR.

Please ensure you've addressed or included references to any related
issues.

Tips:
- Use keywords like "closes" or "fixes" followed by an issue number to
automatically close related issues when the PR is merged (e.g., "closes
#123" or "fixes #123").
- Describe the changes made in the PR.
- Ensure the PR has one of the required tags (kind:fix, kind:misc,
kind:break!, kind:refactor, kind:feat, kind:deps, kind:docs, kind:ci,
kind:chore, kind:testing)

-->

Added these in the run up to cutting 0.12.0 so hopefully the tag/release
pipeline would generate signed binaries and not halt on any of these
three flakey test runs. Setting these back to fail explicitly so we can
see them go red and feel bad, and now start to fix them
  • Loading branch information
ramin committed Nov 10, 2023
1 parent 70d7a39 commit 48352eb
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/go-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ jobs:

- name: execute test run
run: make test-unit-race
continue-on-error: true

integration_test:
needs: [lint, go_mod_tidy_check]
Expand All @@ -136,8 +135,6 @@ jobs:

- name: Swamp Tests
run: make test-swamp
continue-on-error: true

- name: Swamp Tests with Race Detector
run: make test-swamp-race
continue-on-error: true

0 comments on commit 48352eb

Please sign in to comment.