Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove 'continue-on-error' configuration from flakey tests #2913

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

ramin
Copy link
Contributor

@ramin ramin commented Nov 8, 2023

Added these in the run up to cutting 0.12.0 so hopefully the tag/release pipeline would generate signed binaries and not halt on any of these three flakey test runs. Setting these back to fail explicitly so we can see them go red and feel bad, and now start to fix them

@ramin ramin enabled auto-merge (squash) November 9, 2023 13:56
@ramin ramin requested a review from MSevey November 9, 2023 13:56
@codecov-commenter
Copy link

Codecov Report

Merging #2913 (aaa22aa) into main (70d7a39) will decrease coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2913      +/-   ##
==========================================
- Coverage   51.71%   51.38%   -0.33%     
==========================================
  Files         167      167              
  Lines       10812    10812              
==========================================
- Hits         5591     5556      -35     
- Misses       4727     4761      +34     
- Partials      494      495       +1     

see 8 files with indirect coverage changes

@ramin ramin merged commit 48352eb into main Nov 10, 2023
24 of 33 checks passed
@ramin ramin deleted the chore/ci/ramin/allow-failures branch November 10, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:ci CI related PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants