fix(p2p/discovery): Unregister metrics callback on close (#3280)

Self explanatory
celestiaorg · Apr 21, 2024 · ba50a25 · ba50a25
1 parent f30b5fb
commit ba50a25
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/share/p2p/discovery/discovery.go b/share/p2p/discovery/discovery.go
@@ -114,7 +114,7 @@ func (d *Discovery) Start(context.Context) error {
 
 func (d *Discovery) Stop(context.Context) error {
 	d.cancel()
-	return nil
+	return d.metrics.close()
 }
 
 // Peers provides a list of discovered peers in the given topic.

diff --git a/share/p2p/discovery/metrics.go b/share/p2p/discovery/metrics.go
@@ -37,6 +37,8 @@ type metrics struct {
 	advertise        metric.Int64Counter // attributes: failed[bool]
 	peerAdded        metric.Int64Counter
 	peerRemoved      metric.Int64Counter
+
+	clientReg metric.Registration
 }
 
 // WithMetrics turns on metric collection in discoery.
@@ -107,13 +109,22 @@ func initMetrics(d *Discovery) (*metrics, error) {
 		observer.ObserveInt64(backOffSize, int64(d.connector.Size()))
 		return nil
 	}
-	_, err = meter.RegisterCallback(callback, peersAmount, backOffSize)
+
+	metrics.clientReg, err = meter.RegisterCallback(callback, peersAmount, backOffSize)
 	if err != nil {
 		return nil, fmt.Errorf("registering metrics callback: %w", err)
 	}
+
 	return metrics, nil
 }
 
+func (m *metrics) close() error {
+	if m == nil {
+		return nil
+	}
+	return m.clientReg.Unregister()
+}
+
 func (m *metrics) observeFindPeers(ctx context.Context, isEnoughPeers bool) {
 	if m == nil {
 		return