Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(p2p/discovery): Unregister metrics callback on close #3280

Merged
merged 2 commits into from
Apr 5, 2024
Merged

fix(p2p/discovery): Unregister metrics callback on close #3280

merged 2 commits into from
Apr 5, 2024
+13 −2

Conversation

renaynay
Copy link
Member

Self explanatory

@renaynay renaynay added the kind:fix Attached to bug-fixing PRs label Mar 26, 2024
@renaynay renaynay self-assigned this Mar 26, 2024
Wondertan
Wondertan approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Iirc, the same issue is also in daser. Can you check?

@renaynay
Copy link
Member Author

@Wondertan it happens in a lot of places unfortunately. I'll make a subsequent PR to fix them all.

@renaynay renaynay enabled auto-merge (squash) April 5, 2024 09:49
@renaynay renaynay merged commit 6242fc1 into celestiaorg:main Apr 5, 2024
26 checks passed
Wondertan pushed a commit that referenced this pull request Apr 21, 2024
@renaynay @Wondertan
fix(p2p/discovery): Unregister metrics callback on close (#3280)
ba50a25 
Self explanatory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramin ramin ramin approved these changes

@walldiss walldiss walldiss approved these changes

@Wondertan Wondertan Wondertan approved these changes

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

Assignees

@renaynay renaynay

Labels
kind:fix Attached to bug-fixing PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@renaynay @ramin @walldiss @Wondertan