Skip to content

Commit

Permalink
chore(logs): lower bitswap-server verbosity (#3434)
Browse files Browse the repository at this point in the history 
```
May 24 04:10:51 celestia[1806932]: 2024-05-24T04:10:51.439Z        INFO        bitswap-server        server/server.go:547        Bitswap Client ReceiveError: Application error 0x0 (local)
May 24 04:10:51 celestia[1806932]: 2024-05-24T04:10:51.440Z        INFO        bitswap-server        server/server.go:547        Bitswap Client ReceiveError: stream reset
May 24 04:10:51 celestia[1806932]: 2024-05-24T04:10:51.443Z        INFO        bitswap-server        server/server.go:547        Bitswap Client ReceiveError: Application error 0x0 (local)
May 24 04:10:51 celestia[1806932]: 2024-05-24T04:10:51.443Z        INFO        bitswap-server        server/server.go:547        Bitswap Client ReceiveError: Application error 0x0 (local)
May 24 04:10:51 celestia[1806932]: 2024-05-24T04:10:51.443Z        INFO        bitswap-server        server/server.go:547        Bitswap Client ReceiveError: Application error 0x0 (local)
May 24 04:10:51 celestia[1806932]: 2024-05-24T04:10:51.443Z        INFO        bitswap-server        server/server.go:547        Bitswap Client ReceiveError: Application error 0x0 (local)
May 24 04:10:51 celestia[1806932]: 2024-05-24T04:10:51.443Z        INFO        bitswap-server        server/server.go:547        Bitswap Client ReceiveError: Application error 0x0 (local)

```
These logs are pretty annoying, and this PR jams them.

However, the amount of those logs coming from stream resets is a bit concerning, and a quick look through the code path does not give me an idea of what could go wrong. I propose to shut them for now and observe if something goes wrong because currently, things are running well 

Fixes #3426
  • Loading branch information
@Wondertan @ramin
Wondertan authored and ramin committed Jun 6, 2024
1 parent b23427d commit e23134c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions logs/logs.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ func SetAllLoggers(level logging.LogLevel) {
_ = logging.SetLogLevel("dagstore", "WARN")
_ = logging.SetLogLevel("dagstore/upgrader", "WARN")
_ = logging.SetLogLevel("fx", "FATAL")
_ = logging.SetLogLevel("bitswap-server", "WARN")
}

func SetDebugLogging() {
Expand Down

0 comments on commit e23134c

Please sign in to comment.