chore(logs): lower bitswap-server verbosity #3434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd,
walldiss,
ramin and
cristaloleg
as code owners
cristaloleg
approved these changes
May 24, 2024
ramin
approved these changes
May 24, 2024
|
The amount of logs is concerning and worth keep the issue open or create new one to identify the root cause, as there might be underlying issues leading to logs, like misconfiguration or incorrect error handling. |
walldiss
approved these changes
May 24, 2024
ramin
pushed a commit
that referenced
this pull request
Jun 6, 2024
``` May 24 04:10:51 celestia[1806932]: 2024-05-24T04:10:51.439Z INFO bitswap-server server/server.go:547 Bitswap Client ReceiveError: Application error 0x0 (local) May 24 04:10:51 celestia[1806932]: 2024-05-24T04:10:51.440Z INFO bitswap-server server/server.go:547 Bitswap Client ReceiveError: stream reset May 24 04:10:51 celestia[1806932]: 2024-05-24T04:10:51.443Z INFO bitswap-server server/server.go:547 Bitswap Client ReceiveError: Application error 0x0 (local) May 24 04:10:51 celestia[1806932]: 2024-05-24T04:10:51.443Z INFO bitswap-server server/server.go:547 Bitswap Client ReceiveError: Application error 0x0 (local) May 24 04:10:51 celestia[1806932]: 2024-05-24T04:10:51.443Z INFO bitswap-server server/server.go:547 Bitswap Client ReceiveError: Application error 0x0 (local) May 24 04:10:51 celestia[1806932]: 2024-05-24T04:10:51.443Z INFO bitswap-server server/server.go:547 Bitswap Client ReceiveError: Application error 0x0 (local) May 24 04:10:51 celestia[1806932]: 2024-05-24T04:10:51.443Z INFO bitswap-server server/server.go:547 Bitswap Client ReceiveError: Application error 0x0 (local) ``` These logs are pretty annoying, and this PR jams them. However, the amount of those logs coming from stream resets is a bit concerning, and a quick look through the code path does not give me an idea of what could go wrong. I propose to shut them for now and observe if something goes wrong because currently, things are running well Fixes #3426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These logs are pretty annoying, and this PR jams them.
However, the amount of those logs coming from stream resets is a bit concerning, and a quick look through the code path does not give me an idea of what could go wrong. I propose to shut them for now and observe if something goes wrong because currently, things are running well
Fixes #3426