Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log(throughout codebase): Change log to DAH.String() instead of DAH.Hash() anywhere where we try to log the hash of the DataAvailabilityHeader/ Root #1898

Closed
renaynay opened this issue Mar 13, 2023 · 2 comments · Fixed by #1971
Closed

log(throughout codebase): Change log to DAH.String() instead of DAH.Hash() anywhere where we try to log the hash of the DataAvailabilityHeader/ Root #1898

renaynay opened this issue Mar 13, 2023 · 2 comments · Fixed by #1971
Assignees
@Ray-Escobar
Labels
good first issue Good for newcomers

Comments

@renaynay
Copy link
Member

No description provided.

@renaynay renaynay added the good first issue Good for newcomers label Mar 13, 2023
@Ray-Escobar
Copy link
Contributor

Ray-Escobar commented Mar 24, 2023 •
edited
Loading

Hi, can you assign it to me?

Think I have found all the changes already

@renaynay
Copy link
Member Author

Hi @Ray-Escobar please go ahead! I will assign you :)

Ray-Escobar added a commit to Ray-Escobar/celestia-node that referenced this issue Mar 27, 2023
@Ray-Escobar
chore(das/share): Change log from DAH.Hash() to DAH.String()
6fe5f69 
Changes log input to use the string method for both the
DataAvailabilityHeader and Root.

Fixes celestiaorg#1898
@Ray-Escobar Ray-Escobar mentioned this issue Mar 27, 2023
Merged
2 tasks
Ray-Escobar added a commit to Ray-Escobar/celestia-node that referenced this issue Mar 27, 2023
@Ray-Escobar
chore(das/share): Change log from DAH.Hash() to DAH.String()
4ee6459 
Changes log input to use the string method for both the
DataAvailabilityHeader and Root.

Fixes celestiaorg#1898
Ray-Escobar added a commit to Ray-Escobar/celestia-node that referenced this issue Mar 28, 2023
@Ray-Escobar
chore(das/share): Change log from DAH.Hash() to DAH.String()
26eb3aa 
Changes log input to use the string method for both the
DataAvailabilityHeader and Root.

Fixes celestiaorg#1898
Ray-Escobar added a commit to Ray-Escobar/celestia-node that referenced this issue Mar 30, 2023
@Ray-Escobar
chore(das/share): Change log from DAH.Hash() to DAH.String()
51002a6 
Changes log input to use the string method for both the
DataAvailabilityHeader and Root.

Fixes celestiaorg#1898
walldiss pushed a commit that referenced this issue Apr 6, 2023
@Ray-Escobar
das/share: Change log from DAH.Hash() to DAH.String() (#1971)
9c0a5fb 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

Changes log input to use the string method for both the
DataAvailabilityHeader and Root.

Fixes #1898

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->


- [x] Required CI checks are passing
- [x] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ray-Escobar Ray-Escobar

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

das/share: Change log from DAH.Hash() to DAH.String() Ray-Escobar/celestia-node
2 participants
@renaynay @Ray-Escobar