Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getters/shrex: GetEDS does not respect parent context deadline in all cases #2110

Closed
Tracked by #2106
distractedm1nd opened this issue Apr 20, 2023 · 1 comment · Fixed by #2115
Closed
Tracked by #2106

getters/shrex: GetEDS does not respect parent context deadline in all cases #2110

distractedm1nd opened this issue Apr 20, 2023 · 1 comment · Fixed by #2115
Assignees
@distractedm1nd
Labels
area:shares Shares and samples bug Something isn't working

Comments

@distractedm1nd
Copy link
Member

distractedm1nd commented Apr 20, 2023 •
edited
Loading

There is an assumption inside of GetEDS that the call to Peer will check context for a deadline. This is not always the case, and we should be explicit about checking contexts anyways.
@distractedm1nd distractedm1nd mentioned this issue Apr 20, 2023
Open
@distractedm1nd distractedm1nd added bug Something isn't working area:shares Shares and samples and removed needs:triage labels Apr 20, 2023
@distractedm1nd distractedm1nd self-assigned this Apr 20, 2023
@distractedm1nd
Copy link
Member Author

Note: This relates to the spam that we have seen clients generate. They get into a state where they request a datahash without ever stopping.

This was referenced Apr 20, 2023
Closed
Merged
Closed
walldiss added a commit that referenced this issue Apr 26, 2023
@distractedm1nd @renaynay @walldiss
fix(share/shrex): hotfixes for shrex getter respecting context (#2115)
fc691ea 
Closes #2110, related
to #2109.
Only adds a hotfix for 2109

---------

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Co-authored-by: Vlad <vlad@celestia.org>
Co-authored-by: Vlad <13818348+walldiss@users.noreply.github.com>
Wondertan pushed a commit that referenced this issue Apr 27, 2023
@distractedm1nd @renaynay
@walldiss @Wondertan
fix(share/shrex): hotfixes for shrex getter respecting context (#2115)
c62f5c9 
Closes #2110, related
to #2109.
Only adds a hotfix for 2109

---------

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Co-authored-by: Vlad <vlad@celestia.org>
Co-authored-by: Vlad <13818348+walldiss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@distractedm1nd distractedm1nd

Labels
area:shares Shares and samples bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@distractedm1nd