node: start and stop block service by notification from lifecycle #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
liamsi,
mattdf,
renaynay and
Wondertan
as code owners
Wondertan
requested changes
Oct 29, 2021
Wondertan
reviewed
Nov 2, 2021
Wondertan
reviewed
Nov 2, 2021
Wondertan
reviewed
Nov 2, 2021
Wondertan
reviewed
Nov 2, 2021
Wondertan
reviewed
Nov 2, 2021
|
@vgonkivs, last thing: pls squash your commits here into one(and force push it) and the PR is done 👍🏻 |
vgonkivs
force-pushed
the
pass_lifecycle_to_block_service
branch
from
f82c315
to
20fa816
Compare
Wondertan
approved these changes
Nov 3, 2021
|
@renaynay, pls take a look |
renaynay
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added both OnStart and OnStop hooks from block service and now it could not start/stop manually.
Closes #134