Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/block, node: Make services added to the node take a Lifecycle so they can be started via fx #134

Closed
renaynay opened this issue Oct 12, 2021 · 4 comments · Fixed by #158
Labels
area:block Raw blocks and erasure coded blocks area:node Node

Comments

@renaynay
Copy link
Member

From @Wondertan:
In the BlockService constructor also do receive lifecycle and pass to it a Hook with Start/Stop calling respective Blocksetvice methods. Take a look in node/p2p for examples.

@renaynay renaynay added area:node Node area:block Raw blocks and erasure coded blocks labels Oct 12, 2021
@vgonkivs
Copy link
Member

Hi @renaynay. May I take this one if it's still relevant?

@renaynay
Copy link
Member Author

yes! Thank you @vgonkivs :)

@vgonkivs
Copy link
Member

Hi @renaynay , I've prepared a PR with fix.

Also I would like to point out that sometimes I'm running into an issue when stopping nodes. It seems that sometimes there are not enough time in timeout(15 secs) to stop them. May be I can increase timeout for graceful shutdown or should it be investigated more deeper in scope of another task?

@renaynay
Copy link
Member Author

Hi @vgonkivs thank you so much for the PR, looking into it now.

Regarding timeout, we could maybe allow for 30 seconds, but not much more than that. If it regularly times out after 30 seconds, it should be investigated further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:block Raw blocks and erasure coded blocks area:node Node
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants