chore(deps): bump go.uber.org/fx from 1.18.2 to 1.19.2 #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
dependabot
bot
force-pushed
the
dependabot/go_modules/go.uber.org/fx-1.19.2
branch
from
9e9722b
to
91eb0aa
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/go.uber.org/fx-1.19.2
branch
from
91eb0aa
to
15cfd1a
Compare
vgonkivs
previously approved these changes
Feb 27, 2023
Wondertan
requested changes
Feb 27, 2023
dependabot
bot
dismissed stale reviews from vgonkivs and renaynay
via
f06b80f
dependabot
bot
force-pushed
the
dependabot/go_modules/go.uber.org/fx-1.19.2
branch
5 times, most recently
from
22b62be
to
d99f5b6
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/go.uber.org/fx-1.19.2
branch
4 times, most recently
from
b1f4f0c
to
8c069bc
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/go.uber.org/fx-1.19.2
branch
4 times, most recently
from
507476d
to
1e05319
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/go.uber.org/fx-1.19.2
branch
3 times, most recently
from
ac06a21
to
57f017f
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/go.uber.org/fx-1.19.2
branch
2 times, most recently
from
d04f9cb
to
f1a1cfa
Compare
dependabot
bot
force-pushed
the
dependabot/go_modules/go.uber.org/fx-1.19.2
branch
2 times, most recently
from
3e6fb82
to
67b8f15
Compare
Bumps [go.uber.org/fx](https://github.com/uber-go/fx) from 1.18.2 to 1.19.2. - [Release notes](https://github.com/uber-go/fx/releases) - [Changelog](https://github.com/uber-go/fx/blob/v1.19.2/CHANGELOG.md) - [Commits](uber-go/fx@v1.18.2...v1.19.2) --- updated-dependencies: - dependency-name: go.uber.org/fx dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/go.uber.org/fx-1.19.2
branch
from
67b8f15
to
9346b9f
Compare
Wondertan
added a commit
that referenced
this pull request
Apr 18, 2023
This PR solves two problems: * Updates FX and fixes issues we observed in [the PR](#1801) * Fixes #2041 Surprisingly, those two problems were related, so I decided to fix them once and for all. The issue with FX happens after [this change](uber-go/fx#983). The outcome of this change is summarized: > In other words, lifecycle hook annotations can no longer pull in extra > dependencies outside of things on which > the annotated constructor is dependent, results that the annotated > constructor provides, context.Context > object which is injected by Lifecycle, and the Lifecycle object itself. Our current code does pull extra dependencies in the service having `modfraud.Lifecycle` on them, like [DASer](https://github.com/celestiaorg/celestia-node/blob/main/nodebuilder/das/module.go#L47). Specifically, it pulls FraudService, and this is no longer allowed. This forces us to rewrite the fraud lifecycling and here is the solution, which additionally satisfies #2041. This also unblocks #2040, which is now implemented in celestiaorg/go-fraud#1 I tried to split FX update and the refactor into two diff PRs. However, the solution does not work with the old FX version, so we have to couple those. The chain here is that I needed a new version of FX that fixes `OnStart/OnStop` hooks, and updating created the whole story. The PR that does clean-ups basing on new version of FX will com right after.
|
Superseded by #2199. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps go.uber.org/fx from 1.18.2 to 1.19.2.
Release notes
Sourced from go.uber.org/fx's releases.
Changelog
Sourced from go.uber.org/fx's changelog.
Commits
d169de9Prepare for v1.19.2 releasecd386e1Pin Dig to v1.16.1 (#1029)d9d9838Prepare for release v1.19.1 (#1021)91e752cAllow stopping app after Stop() has been called (#1019)f0d73c6Fix Start ctx expiration making app unstoppable (#1017)213eb86Back to development (#1012)887c07cRelease v1.19.0 (#1011)24589d6Upgrade Dig to v1.16.0 (#1010)44fddbaci/docs: Run on tagged releases only (#1009)cb664abRemove extraneous error logs in lifecycle deadline exceed errors (#1005)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)