docs: Add share p2p documentation #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrandz
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
renaynay
changed the title
|
@renaynay on a quick glance are these docs still representative of what they document? if so, I'll take this over and try and bring it home |
|
@derrandz if you fix these too long line lint errors quickly i'll merge this. otherwise i'll close out and ill add more documentation as we get closer to mainnet in coming month |
|
Cool, will fix and let's merge |
|
@ramin made a few corrections to the docs and made the linter happy. Should be ready to go |
Codecov Report
@@ Coverage Diff @@
## main #2008 +/- ##
==========================================
+ Coverage 51.51% 51.59% +0.08%
==========================================
Files 162 163 +1
Lines 10755 10784 +29
==========================================
+ Hits 5540 5564 +24
- Misses 4734 4742 +8
+ Partials 481 478 -3
|
ramin
suggested changes
Sep 13, 2023
distractedm1nd
approved these changes
Sep 20, 2023
|
Let's merge this and we can make edits as necessary to the contents, this PR is getting stale |
vgonkivs
pushed a commit
to vgonkivs/celestia-node
that referenced
this pull request
Oct 5, 2023
## Overview Self-explanatory ## How to Test Changes Launch: ``` $ godoc -http=:6060 ``` And browse the impacted packages. ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords --------- Co-authored-by: ramin <raminkeene@gmail.com> Co-authored-by: Ryan <ryan@celestia.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Self-explanatory
How to Test Changes
Launch:
And browse the impacted packages.
Checklist