feat(share/discovery): add discovery metrics #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ery and advertisements
- rework errorgroup loop to respect findCtx and stop when it is canceled - use parent context instead of findCtx for handlePeer to not cancel connection when it is half done - allow wg pool be cancelable from another routine
- send update notification asap
Wondertan
reviewed
May 3, 2023
renaynay
reviewed
May 3, 2023
- add stuck counter
walldiss
force-pushed
the
discovery_metrics
branch
from
764de47
to
894ee4e
Compare
Wondertan
previously approved these changes
May 9, 2023
|
But needs to be rebases |
derrandz
previously approved these changes
May 9, 2023
# Conflicts: # share/availability/discovery/discovery.go
Wondertan
previously approved these changes
May 9, 2023
renaynay
previously approved these changes
May 11, 2023
walldiss
added a commit
that referenced
this pull request
May 11, 2023
## Overview Use same approach as discussed in #2155 (comment)
# Conflicts: # share/p2p/metrics.go
Wondertan
approved these changes
May 11, 2023
distractedm1nd
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds metrics for discovery component