Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(share/discovery): add discovery metrics #2155

Merged
merged 63 commits into from
May 11, 2023
Merged

feat(share/discovery): add discovery metrics #2155

merged 63 commits into from
May 11, 2023

Commits on Apr 27, 2023

  1. prog

    @distractedm1nd @Wondertan
    distractedm1nd authored and Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    3e5abdb View commit details
    Browse the repository at this point in the history

  2. only adding connected peers

    @distractedm1nd @Wondertan
    distractedm1nd authored and Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    e3b8595 View commit details
    Browse the repository at this point in the history

  3. improve logic a bit

    @Wondertan
    Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    1f9a052 View commit details
    Browse the repository at this point in the history

  4. add connecting map

    @Wondertan
    Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    f058a21 View commit details
    Browse the repository at this point in the history

  5. cleanup the connecting map

    @Wondertan
    Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    48732ff View commit details
    Browse the repository at this point in the history

  6. limit connections

    @Wondertan
    Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    3f3c287 View commit details
    Browse the repository at this point in the history

  7. dialTimeout -> connectTimeout

    @Wondertan
    Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    0148dd2 View commit details
    Browse the repository at this point in the history

  8. unlock on error

    @Wondertan
    Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    23b590e View commit details
    Browse the repository at this point in the history

  9. make connect timeout a constatnt

    @Wondertan
    Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    9943c17 View commit details
    Browse the repository at this point in the history

  10. discovery parameters

    @Wondertan
    Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    e58c3d5 View commit details
    Browse the repository at this point in the history

  11. actually break the config, refine defaults and allow disabling discov… 

    …ery and advertisements
    @Wondertan
    Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    c717917 View commit details
    Browse the repository at this point in the history

  12. fixing log and peer limit deactivation comment

    @distractedm1nd @Wondertan
    distractedm1nd authored and Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    ab03470 View commit details
    Browse the repository at this point in the history

  13. removing storage of ctx on Discovery

    @distractedm1nd @Wondertan
    distractedm1nd authored and Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    7cf7287 View commit details
    Browse the repository at this point in the history

  14. notify subscribers directly after adding

    @distractedm1nd @Wondertan
    distractedm1nd authored and Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    86a8a06 View commit details
    Browse the repository at this point in the history

  15. restarting FindPeers until limit is reached

    @distractedm1nd @Wondertan
    distractedm1nd authored and Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    14adb1c View commit details
    Browse the repository at this point in the history

  16. respecting ctx in findPeers loop

    @distractedm1nd @Wondertan
    distractedm1nd authored and Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    8b8941f View commit details
    Browse the repository at this point in the history

  17. start discovery asap

    @Wondertan
    Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    c40f68e View commit details
    Browse the repository at this point in the history

  18. case for already connected peer

    @Wondertan
    Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    4917621 View commit details
    Browse the repository at this point in the history

  19. protect rather than tag

    @Wondertan
    Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    ca3a4be View commit details
    Browse the repository at this point in the history

  20. first working iteration for tests

    @Wondertan
    Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    f7c413a View commit details
    Browse the repository at this point in the history

  21. set and backoff audit + remove retrying for FindPeers

    @Wondertan
    Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    c5e0d00 View commit details
    Browse the repository at this point in the history

  22. the least flaky version of the test; 2/100 fails

    @Wondertan
    Wondertan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    c382f16 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. - stop wait group when enough peers found 

    - rework errorgroup loop to respect findCtx and stop when it is canceled
- use parent context instead of findCtx for handlePeer to not cancel connection when it is half done
- allow wg pool be cancelable from another routine
    @walldiss
    walldiss committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    d96ade7 View commit details
    Browse the repository at this point in the history

  2. log Error if Discovery is unable to find new peers for long time

    @walldiss
    walldiss committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    2005330 View commit details
    Browse the repository at this point in the history

  3. rerun findPeers if previous run stopped too early

    @walldiss
    walldiss committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    37a159e View commit details
    Browse the repository at this point in the history

  4. - do not connect to already connected peers 

     - send update notification asap
    @walldiss
    walldiss committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    82eb331 View commit details
    Browse the repository at this point in the history

  5. improve logs

    @walldiss
    walldiss committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    36deab8 View commit details
    Browse the repository at this point in the history

  6. increase time

    @Wondertan
    Wondertan committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    d83f2ef View commit details
    Browse the repository at this point in the history

  7. another attempt to deflake the test

    @Wondertan
    Wondertan committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    c154073 View commit details
    Browse the repository at this point in the history

  8. various fixes

    @Wondertan
    Wondertan committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    cf20647 View commit details
    Browse the repository at this point in the history

  9. update backoff logic to deflake test

    @Wondertan
    Wondertan committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    d139979 View commit details
    Browse the repository at this point in the history

  10. more fixes

    @Wondertan
    Wondertan committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    72548fb View commit details
    Browse the repository at this point in the history

  11. decrease backoff timeout

    @Wondertan
    Wondertan committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    2869a45 View commit details
    Browse the repository at this point in the history

  12. drain ticker and timer channel before reset

    @walldiss
    walldiss committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    c723d5d View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2023

  1. unflake the test by removing unnecessary stop of the timer

    @Wondertan
    Wondertan committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    439580b View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. log as found only valid peers

    @Wondertan
    Wondertan committed May 2, 2023
    Configuration menu
    Copy the full SHA
    a4d2b27 View commit details
    Browse the repository at this point in the history

  2. add metrics for discovery

    @walldiss
    walldiss committed May 2, 2023
    Configuration menu
    Copy the full SHA
    a0b0c1c View commit details
    Browse the repository at this point in the history

  3. fix shadow read for add peers to set

    @walldiss
    walldiss committed May 2, 2023
    Configuration menu
    Copy the full SHA
    dd8abcf View commit details
    Browse the repository at this point in the history

  4. another backoff cleanup

    @Wondertan
    Wondertan committed May 2, 2023
    Configuration menu
    Copy the full SHA
    32050eb View commit details
    Browse the repository at this point in the history

  5. Merge branch 'discovery-dial-timeout' into discovery_metrics 

    # Conflicts:
#	share/availability/discovery/discovery.go
    @walldiss
    walldiss committed May 2, 2023
    Configuration menu
    Copy the full SHA
    18b4eb6 View commit details
    Browse the repository at this point in the history

  6. small fix

    @Wondertan
    Wondertan committed May 2, 2023
    Configuration menu
    Copy the full SHA
    de865a9 View commit details
    Browse the repository at this point in the history

  7. add delay for findpeers retry

    @walldiss
    walldiss committed May 2, 2023
    Configuration menu
    Copy the full SHA
    0b56b79 View commit details
    Browse the repository at this point in the history

  8. make findPeers fast retry delay a var to modify it in tests

    @walldiss
    walldiss committed May 2, 2023
    Configuration menu
    Copy the full SHA
    0796147 View commit details
    Browse the repository at this point in the history

  9. fix comment

    @Wondertan
    Wondertan committed May 2, 2023
    Configuration menu
    Copy the full SHA
    8eed668 View commit details
    Browse the repository at this point in the history

  10. notify when we actually need the discovery, instead of periodic check… 

    …ing and rebrand the discovery interval
    @Wondertan
    Wondertan committed May 2, 2023
    Configuration menu
    Copy the full SHA
    38d97e9 View commit details
    Browse the repository at this point in the history

  11. fix comment

    @Wondertan
    Wondertan committed May 2, 2023
    Configuration menu
    Copy the full SHA
    c8fb086 View commit details
    Browse the repository at this point in the history

  12. simplify the code further

    @Wondertan
    Wondertan committed May 2, 2023
    Configuration menu
    Copy the full SHA
    6cb5cdf View commit details
    Browse the repository at this point in the history

  13. rework tests to use real swarm. Mocknet has some bug regarding connec… 

    …tion closage that cause deadlock and flakes
    @Wondertan
    Wondertan committed May 2, 2023
    Configuration menu
    Copy the full SHA
    0ebf3af View commit details
    Browse the repository at this point in the history

  14. ensurePeers should depend on global state rather than local

    @Wondertan
    Wondertan committed May 2, 2023
    Configuration menu
    Copy the full SHA
    3ba19e9 View commit details
    Browse the repository at this point in the history

  15. int back to uint

    @Wondertan
    Wondertan committed May 2, 2023
    Configuration menu
    Copy the full SHA
    d8b85d6 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. apply review suggestions

    @walldiss
    walldiss committed May 3, 2023
    Configuration menu
    Copy the full SHA
    8e20342 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'discovery-dial-timeout' into discovery_metrics 

    # Conflicts:
#	share/availability/discovery/discovery.go
    @walldiss
    walldiss committed May 3, 2023
    Configuration menu
    Copy the full SHA
    2ebbf3c View commit details
    Browse the repository at this point in the history

  3. rebase

    @walldiss
    walldiss committed May 3, 2023
    Configuration menu
    Copy the full SHA
    0b56f67 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main-celestia' into discovery_metrics 

    # Conflicts:
#	share/availability/discovery/discovery.go
    @walldiss
    walldiss committed May 3, 2023
    Configuration menu
    Copy the full SHA
    e88f671 View commit details
    Browse the repository at this point in the history

  5. rebase

    @walldiss
    walldiss committed May 3, 2023
    Configuration menu
    Copy the full SHA
    1512b10 View commit details
    Browse the repository at this point in the history

  6. rebase

    @walldiss
    walldiss committed May 3, 2023
    Configuration menu
    Copy the full SHA
    d498cf3 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main-celestia' into discovery_metrics 

    # Conflicts:
#	nodebuilder/share/opts.go
    @walldiss
    walldiss committed May 3, 2023
    Configuration menu
    Copy the full SHA
    7dc8e98 View commit details
    Browse the repository at this point in the history

  8. rebase

    @walldiss
    walldiss committed May 3, 2023
    Configuration menu
    Copy the full SHA
    6cb5cf9 View commit details
    Browse the repository at this point in the history

  9. - apply review suggestions 

    - add stuck counter
    @walldiss
    walldiss committed May 3, 2023
    Configuration menu
    Copy the full SHA
    6bfcb8a View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. use user context for metrics observation

    @walldiss
    walldiss committed May 9, 2023
    Configuration menu
    Copy the full SHA
    894ee4e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main-celestia' into discovery_metrics 

    # Conflicts:
#	share/availability/discovery/discovery.go
    @walldiss
    walldiss committed May 9, 2023
    Configuration menu
    Copy the full SHA
    f722beb View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Merge branch 'main' into discovery_metrics

    @walldiss
    walldiss committed May 10, 2023
    Configuration menu
    Copy the full SHA
    bff848e View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Merge branch 'main-celestia' into discovery_metrics 

    # Conflicts:
#	share/p2p/metrics.go
    @walldiss
    walldiss committed May 11, 2023
    Configuration menu
    Copy the full SHA
    d170d2b View commit details
    Browse the repository at this point in the history