Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd, service/header: rename genesis to trustedHash to avoid confusion, extract flags to common var for re-use #229

Merged
merged 2 commits into from
Nov 29, 2021
Merged

cmd, service/header: rename genesis to trustedHash to avoid confusion, extract flags to common var for re-use #229

merged 2 commits into from
Nov 29, 2021

Conversation

renaynay
Copy link
Member

This PR:

  • renames genesis to trustedHash in the codebase to avoid confusion
  • extracts flags to common variable for re-use between commands start and init

@renaynay renaynay added area:config CLI and config area:header Extended header labels Nov 23, 2021
adlerjohn
adlerjohn reviewed Nov 23, 2021
View reviewed changes
node/services/config.go Outdated Show resolved Hide resolved
@renaynay @adlerjohn
Update node/services/config.go
6d481cf 
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
Wondertan
Wondertan reviewed Nov 24, 2021
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for deduplication

cmd/flags.go Show resolved Hide resolved
cmd/start.go Show resolved Hide resolved
@renaynay renaynay merged commit 803ff1c into celestiaorg:main Nov 29, 2021
@renaynay renaynay deleted the flags-changes branch November 29, 2021 15:02
@Wondertan Wondertan mentioned this pull request Dec 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@Wondertan Wondertan Wondertan approved these changes

@liamsi liamsi Awaiting requested review from liamsi

@mattdf mattdf Awaiting requested review from mattdf

Assignees
No one assigned
Labels
area:config CLI and config area:header Extended header
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renaynay @adlerjohn @Wondertan