fix(rpc): fix commands handling

[vgonkivs]

Overview

Fixes all found rpc issues

Fixes #2503 and #2500

Checklist

• New and updated code has appropriate documentation
• New and updated code has new and/or updated testing
• Required CI checks are passing
• Visual proof for any user facing features like CLI or documentation updates
• Linked issues closed with keywords

[codecov-commenter]

Codecov Report

Merging #2515 (4c83925) into main (a86ddca) will decrease coverage by 0.43%.
Report is 8 commits behind head on main.
The diff coverage is 19.35%.

@@            Coverage Diff             @@
##             main    #2515      +/-   ##
==========================================
- Coverage   51.39%   50.97%   -0.43%     
==========================================
  Files         158      158              
  Lines       10304    10395      +91     
==========================================
+ Hits         5296     5299       +3     
- Misses       4556     4632      +76     
- Partials      452      464      +12     

Files Changed	Coverage Δ
cmd/celestia/rpc.go	17.56% <0.00%> (-1.07%)	⬇️
share/getters/cascade.go	71.62% <0.00%> (-6.64%)	⬇️
cmd/celestia/blob.go	9.80% <85.71%> (ø)

... and 19 files with indirect coverage changes

[jcstein]

testing out https://based64.xyz (so testing retrieval of submitted plain-text) on this branch and it is not, functioning as expected, so this doesn't resolve the issue #2503 of plain text data that is expected to be returned in base64, being returned as base64

my version matches last commit on this PR:

Semantic version: v0.11.0-rc8-13-ga9ac16a2
Commit: a9ac16a24181094162b54b2ce5e3616037038fdc
Build Date: Thu Jul 27 14:01:39 CEST 2023
System version: arm64/darwin
Golang version: go1.20.2

as an example, i will try to submit "gm" and retrieve base64 that converts to string as "gm". alternatively, as explained in this comment: #2503 (comment) the only difference is i am using the version above

1. celestia light start --core.ip consensus-full-arabica-9.celestia-arabica.com --p2p.network arabica
2. export CELESTIA_NODE_AUTH_TOKEN=$(celestia light auth admin --p2p.network arabica)
3. celestia rpc blob Submit 0x42690c204d39600fddd3 '"gm"'
4. celestia rpc blob GetAll [blockheightfrom#3] 0x42690c204d39600fddd3
5. it should convert to "gm" with some metadata, it doesn't

6. oddly, converting from base64 -> hex and then from hex -> text returns the same data as converting base64 -> text as shown above:

[jcstein]

however, i believe GetSharesByNamespace is working as expected:

celestia rpc share GetSharesByNamespace "$(celestia rpc header GetByHeight 103692 | jq '.result.dah' -r)" 0x42690c204d39600fddd3
{
  "jsonrpc": "2.0",
  "result": [
    {
      "Shares": [
        "AAAAAAAAAAAAAAAAAAAAAAAAAEJpDCBNOWAP3dMBAAAACEltZHRJZz09AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA="
      ],
      "Proof": {
        "start": 1,
        "end": 2,
        "nodes": [
          "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABHBoPeolnLUCIgDXv2uScYcpg3V/gJIIwil8j33b33eH",
          "/////////////////////////////////////////////////////////////////////////////4S2andMgMf77TuFT8NmQm5qoIqmmDsUmUHKwGCZ+wg0"
        ],
        "leaf_hash": null,
        "is_max_namespace_id_ignored": true
      }
    }
  ],
  "id": 1
}

[jcstein]

linking docs context celestiaorg/docs#915 (comment)

[jcstein]

oops 😅

[vgonkivs]

celestia light start --core.ip consensus-full-arabica-9.celestia-arabica.com --p2p.network arabica
export CELESTIA_NODE_AUTH_TOKEN=$(celestia light auth admin --p2p.network arabica)
celestia rpc blob Submit 0x42690c204d39600fddd3 '"gm"'
celestia rpc blob GetAll [blockheightfrom#3] 0x42690c204d39600fddd3
it should convert to "gm" with some metadata, it doesn't

I missed the thing with converting from one type to another and fixed errors in our code.

[vgonkivs]

I feel like #2503 has two potential issues inside.

1. Issue with converting(that @jcstein mentioned in Actual Result)
2. Issue with incorrect handling of rpc commands(see Relevant Output).

This PR is now fixing only issue #2. I need to look deeper what is wrong with the serialisation.

[vgonkivs]

FYI @jcstein , we changed the plaintext flag to base64 in order to convert data to the human readable format by default. To get the data as base64 string, you have to pass --base64=true

vacating

[jcstein]

what happens if no --plaintext or --base64 flag?

[vgonkivs]

Data will be converted to the plain text by default