fix(share/p2p/peers): Prevent making pools for nil DataHash #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested review from
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
|
Actually this doesn't pass tests so converting to draft til i figure it out, will do tmw |
Codecov Report
@@ Coverage Diff @@
## main #2761 +/- ##
==========================================
+ Coverage 51.73% 51.90% +0.17%
==========================================
Files 161 161
Lines 10826 10827 +1
==========================================
+ Hits 5601 5620 +19
+ Misses 4731 4713 -18
Partials 494 494
|
|
Actuallyshould move this to outer validate func |
ramin
previously approved these changes
Sep 26, 2023
…nc mounted on shrexsub
walldiss
approved these changes
Sep 26, 2023
distractedm1nd
approved these changes
Sep 27, 2023
vgonkivs
pushed a commit
to vgonkivs/celestia-node
that referenced
this pull request
Oct 5, 2023
…org#2761) Not critical, but if nil DataHash is broadcasted, node could create pool for empty datahash and just keep it around until garbage collected. Best to short-circuit instead and reject message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not critical, but if nil DataHash is broadcasted, node could create pool for empty datahash and just keep it around until garbage collected. Best to short-circuit instead and reject message.