Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore dependabot in issue-label-automation/automate-labels workflow #2763

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

ramin
Copy link
Contributor

@ramin ramin commented Sep 26, 2023

Overview

  • Ignores triggering the issue-label-automation workflow when a workflow is triggered by dependabot[bot].
  • why?: It always fails as the "check external contributor" action doesn't find a legitimate user
  • this seemed simplest way vs attempting to modify the imported action to allow configuration to ignore dependabot or similar
  • also introduces some minor/nit formatting with a whitespace change

Checklist

  • [n/a] New and updated code has appropriate documentation
  • [n/a] New and updated code has new and/or updated testing
  • Required CI checks are passing
  • [n/a] Visual proof for any user facing features like CLI or documentation updates
  • [n/a] Linked issues closed with keywords

@ramin ramin added ci:actions kind:ci CI related PRs github_actions Pull requests that update GitHub Actions code labels Sep 26, 2023
@ramin ramin self-assigned this Sep 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2763 (87231fe) into main (4c93147) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2763      +/-   ##
==========================================
- Coverage   51.69%   51.63%   -0.06%     
==========================================
  Files         161      161              
  Lines       10826    10826              
==========================================
- Hits         5596     5590       -6     
- Misses       4735     4740       +5     
- Partials      495      496       +1     

see 7 files with indirect coverage changes

@ramin ramin merged commit 849cb67 into main Sep 28, 2023
17 of 19 checks passed
@ramin ramin deleted the chore/ramin/dependabot-workflows branch September 28, 2023 10:27
vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this pull request Oct 5, 2023
…elestiaorg#2763)

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

- Ignores triggering the issue-label-automation workflow when a workflow
is triggered by dependabot[bot].
- why?: It always fails as the "check external contributor" action
doesn't find a legitimate user
- this seemed simplest way vs attempting to modify the imported action
to allow configuration to ignore dependabot or similar
- also introduces some minor/nit formatting with a whitespace change

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [n/a] New and updated code has appropriate documentation
- [n/a] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [n/a] Visual proof for any user facing features like CLI or
documentation updates
- [n/a] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:actions github_actions Pull requests that update GitHub Actions code kind:ci CI related PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants