Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd|node): MutualPeers Node option and CLI flag #280

Merged
merged 9 commits into from
Dec 21, 2021

Conversation

Wondertan
Copy link
Member

Quick PR to add configurability for mutual peers from CLI

@Wondertan Wondertan self-assigned this Dec 8, 2021
Wondertan added a commit that referenced this pull request Dec 8, 2021
liamsi
liamsi previously approved these changes Dec 8, 2021
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/flags.go Outdated Show resolved Hide resolved
cmd/start.go Show resolved Hide resolved
cmd/flags.go Outdated Show resolved Hide resolved
cmd/start.go Show resolved Hide resolved
cmd/start.go Show resolved Hide resolved
@Wondertan
Copy link
Member Author

re__based__

cmd/init.go Outdated Show resolved Hide resolved
cmd/flags.go Outdated Show resolved Hide resolved
cmd/start.go Outdated Show resolved Hide resolved
Wondertan and others added 4 commits December 16, 2021 00:18
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
@Wondertan
Copy link
Member Author

@adlerjohn, added links to multiformats.io/multiaddr

adlerjohn
adlerjohn previously approved these changes Dec 15, 2021
@Wondertan
Copy link
Member Author

@adlerjohn, I put the changelog entry into the wrong category and need your approval again 😅

adlerjohn
adlerjohn previously approved these changes Dec 16, 2021
Bidon15
Bidon15 previously approved these changes Dec 16, 2021
renaynay
renaynay previously approved these changes Dec 20, 2021
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but otherwise LGTM

cmd/flags.go Outdated Show resolved Hide resolved
@Wondertan Wondertan dismissed stale reviews from renaynay, Bidon15, and adlerjohn via 415fa5c December 21, 2021 13:42
@Wondertan Wondertan merged commit afc153d into main Dec 21, 2021
@Wondertan Wondertan deleted the hlib/mutual-flag branch December 21, 2021 14:10
@Wondertan Wondertan restored the hlib/mutual-flag branch January 7, 2022 14:40
@Wondertan Wondertan deleted the hlib/mutual-flag branch January 7, 2022 15:56
Bidon15 pushed a commit to Bidon15/celestia-node that referenced this pull request Jan 11, 2022
Bidon15 pushed a commit to Bidon15/celestia-node that referenced this pull request Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants