Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update golangci-lint #2868

Merged
merged 4 commits into from
Oct 23, 2023
Merged

update golangci-lint #2868

merged 4 commits into from
Oct 23, 2023

Conversation

ramin
Copy link
Contributor

@ramin ramin commented Oct 23, 2023 •
edited
Loading

  • updates golangci-lint to 1.55
  • removes "double cache" when setting up golang, thus removing linter noise (Cannot open file...file exists) so easier to see actual lint errors

closes #2590

@ramin ramin added the kind:ci CI related PRs label Oct 23, 2023
@ramin ramin marked this pull request as ready for review October 23, 2023 11:47
@ramin ramin mentioned this pull request Oct 23, 2023
Closed
@Wondertan
Copy link
Member

@ramin, this is meant to close #2590

@ramin ramin enabled auto-merge (squash) October 23, 2023 13:25
@ramin ramin merged commit e8eaf4a into main Oct 23, 2023
14 of 16 checks passed
@ramin ramin deleted the ci/ramin/lint branch October 23, 2023 13:35
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees
No one assigned
Labels
kind:ci CI related PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update golangci-lint to 1.54.1
3 participants
@ramin @Wondertan @vgonkivs