-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node/store): substantial memory usage improvements #2960
Conversation
* Increases UploadRate to 15 secs. * Send goroutines profiles additionally Extracted from #2960
Part of an effort to decrease the memory footprint for LNs. Headers are pretty beefy. Extracted from #2960
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs lint otherwise i'm fine to RC + deploy to arabica
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems clear. Only comments, perpetually, it'd be nice to do a little refactoring to be able to add some tests cases around some of the behavior (eg: the NumCPU setting that is then validated as compactors > opts.MaxLevels etc) but happy to add that later
NOTE: More details in code comments
TODO:
Closes #2905