fix(blob | nodebuilder/da): Revert custom marshaling for blob.Proof
#3204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
added
kind:fix
renaynay
changed the title
blob.Proof
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3204 +/- ##
==========================================
- Coverage 52.08% 44.88% -7.21%
==========================================
Files 183 265 +82
Lines 11594 14620 +3026
==========================================
+ Hits 6039 6562 +523
- Misses 5043 7303 +2260
- Partials 512 755 +243 ☔ View full report in Codecov by Sentry. |
ramin
approved these changes
Feb 25, 2024
Wondertan
approved these changes
Feb 28, 2024
zvolin
approved these changes
Mar 1, 2024
renaynay
requested review from
vgonkivs,
distractedm1nd and
walldiss
as code owners
|
Breaking(back) btw |
walldiss
approved these changes
Mar 4, 2024
vgonkivs
approved these changes
Mar 4, 2024
|
question, will it be backported and released like a 0.13.1 or when will this be included in any release? |
|
@zvolin a release is imminent, should be later today |
renaynay
added a commit
to renaynay/celestia-node
that referenced
this pull request
Apr 3, 2024
…celestiaorg#3204) Reverts a change introduced in celestiaorg#3146 that unintentionally broke `blob.Proof` serialisation. Resolves celestiaorg#3173
renaynay
added a commit
to renaynay/celestia-node
that referenced
this pull request
Apr 3, 2024
…celestiaorg#3204) Reverts a change introduced in celestiaorg#3146 that unintentionally broke `blob.Proof` serialisation. Resolves celestiaorg#3173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a change introduced in #3146 that unintentionally broke
blob.Proofserialisation.Resolves #3173