-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(blob | nodebuilder/da): Revert custom marshaling for blob.Proof
#3204
Conversation
blob.Proof
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3204 +/- ##
==========================================
- Coverage 52.08% 44.88% -7.21%
==========================================
Files 183 265 +82
Lines 11594 14620 +3026
==========================================
+ Hits 6039 6562 +523
- Misses 5043 7303 +2260
- Partials 512 755 +243 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me. Still wonder what motivated this
Breaking(back) btw |
question, will it be backported and released like a 0.13.1 or when will this be included in any release? |
@zvolin a release is imminent, should be later today |
…celestiaorg#3204) Reverts a change introduced in celestiaorg#3146 that unintentionally broke `blob.Proof` serialisation. Resolves celestiaorg#3173
…celestiaorg#3204) Reverts a change introduced in celestiaorg#3146 that unintentionally broke `blob.Proof` serialisation. Resolves celestiaorg#3173
Reverts a change introduced in #3146 that unintentionally broke
blob.Proof
serialisation.Resolves #3173