Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: Update Docker entrypoint.sh to use new store.path flag name #337

Merged
merged 10 commits into from
Jan 21, 2022
Merged

docker: Update Docker entrypoint.sh to use new store.path flag name #337

merged 10 commits into from
Jan 21, 2022

Conversation

jbowen93
Copy link
Contributor

@jbowen93 jbowen93 commented Jan 10, 2022 •
edited
Loading

Update the docker directories entrypoint.sh file to use the updated flag name, changing repo.path to store.path.

renaynay
renaynay previously approved these changes Jan 10, 2022
View reviewed changes
adlerjohn
adlerjohn reviewed Jan 10, 2022
View reviewed changes
CHANGELOG-PENDING.md Outdated Show resolved Hide resolved
renaynay
renaynay previously approved these changes Jan 12, 2022
View reviewed changes
Wondertan
Wondertan requested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good if your changelog entry also included a link to the PR, pls

@jbowen93 jbowen93 self-assigned this Jan 18, 2022
@jbowen93
Copy link
Contributor Author

Would be good if your changelog entry also included a link to the PR, pls

Resolved

@renaynay renaynay changed the title Update Docker entrypoint.sh to use new store.path flag name docker: Update Docker entrypoint.sh to use new store.path flag name Jan 20, 2022
@renaynay renaynay added the ci:docker Related to docker + dockerhub flow label Jan 20, 2022
@renaynay renaynay merged commit 6da0269 into celestiaorg:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@renaynay renaynay renaynay approved these changes

@liamsi liamsi Awaiting requested review from liamsi

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

Assignees

@jbowen93 jbowen93

Labels
ci:docker Related to docker + dockerhub flow
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbowen93 @adlerjohn @Wondertan @renaynay