Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump go-libp2p-pubsub #3372

Merged
merged 1 commit into from
May 6, 2024
Merged

chore: bump go-libp2p-pubsub #3372

merged 1 commit into from
May 6, 2024

Conversation

Wondertan
Copy link
Member

A regular bump

@Wondertan Wondertan added the kind:deps Pull requests that update a dependency file label May 6, 2024
@Wondertan Wondertan self-assigned this May 6, 2024
@Wondertan
Copy link
Member Author

There is unit test failing. Need some time to debug

     --- FAIL: TestPubSub/valid_height,_valid_hash (0.30s)
        pubsub_test.go:118: 
            	Error Trace:	/home/runner/work/celestia-node/celestia-node/share/p2p/shrexsub/pubsub_test.go:118
            	Error:      	Received unexpected error:
            	            	context deadline exceeded
            	Test:       	TestPubSub/valid_height,_valid_hash

@ramin
Copy link
Contributor

ramin commented May 6, 2024

@Wondertan re-running, might be a flake

@Wondertan
Copy link
Member Author

I tried re-running once and that didn't help

@Wondertan
Copy link
Member Author

The second retry did help. Thanks!

I will park the flake as an issue, as haven't seen it before

@Wondertan Wondertan mentioned this pull request May 6, 2024
Open
@ramin
Copy link
Contributor

ramin commented May 6, 2024

@Wondertan it worked!!! YAY

@Wondertan Wondertan merged commit 320a095 into main May 6, 2024
30 checks passed
@Wondertan Wondertan deleted the hlib/bump-pubsub-2 branch May 6, 2024 16:40
walldiss pushed a commit to walldiss/celestia-node that referenced this pull request May 7, 2024
@Wondertan @walldiss
chore: bump go-libp2p-pubsub (celestiaorg#3372)
0af7eaa 
(cherry picked from commit 320a095)
walldiss pushed a commit to walldiss/celestia-node that referenced this pull request May 7, 2024
@Wondertan @walldiss
chore: bump go-libp2p-pubsub (celestiaorg#3372)
1744870 
(cherry picked from commit 320a095)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramin ramin ramin approved these changes

@walldiss walldiss walldiss approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

Assignees

@Wondertan Wondertan

Labels
kind:deps Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wondertan @ramin @walldiss