Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: changed user UserAgent name #3379

Merged
merged 11 commits into from
May 10, 2024
Merged

refactor: changed user UserAgent name #3379

merged 11 commits into from
May 10, 2024

Conversation

ramin
Copy link
Contributor

@ramin ramin commented May 8, 2024

Opening as a replacement for #2956 which has gone stale. I had added some tests to the original refactoring but original author vanished without allowing admin's to modify the original PR/branch.

From original note:

fixes: #2932 , #2908

@ramin ramin added the kind:refactor Attached to refactoring PRs label May 8, 2024
@Wondertan
Copy link
Member

@ramin, while we are on it, could you include #3381 in here?

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Member

@walldiss walldiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ramin ramin enabled auto-merge (squash) May 10, 2024 09:44
@ramin ramin merged commit 86f4b2a into main May 10, 2024
27 checks passed
@ramin ramin deleted the ramin/celenode-tests branch May 10, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:refactor Attached to refactoring PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modp2p: change user UserAgent name
4 participants