params: Define Network Types #346

Wondertan · 2022-01-13T12:06:55Z

Introduces build package to track global build-related things.
Ability to get Genesis Hash and Bootstrappers for networks
Removes .gitignore entry for build, we anyway don't use it
Removes Network field from Config
- Networks should not be configured, otherwise, a user changing their networks may see weird bugs, like by syncing from one network and then from another in the same Store/Repo.
- Not a breaking change

The use of it will be shown in the next PR.

Closes: #62

…evenet one

… where needed

build/bootstrap.go

build/networks.go

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>

Wondertan · 2022-01-21T21:13:10Z

build -> params

Wondertan · 2022-01-21T21:26:59Z

Tests are failing due to known #340.

node/p2p/p2p.go

params/networks.go

renaynay

already looked through this a few times, LGTM but address @liamsi 's comments.

CHANGELOG-PENDING.md

Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>

Wondertan added 4 commits January 13, 2022 14:00

feat(build): define type for celestia-node networks and add a first d…

5bd01f2

…evenet one

feat(build): a utility to get hardcoded genesis hashes for networks

562d8a4

feat(build): a utility to get hardcoded bootstrap peers for networks

bb8c481

gitignore: remove entry for build package as not used

9d4ea8b

Wondertan self-assigned this Jan 13, 2022

Wondertan requested review from liamsi and renaynay as code owners January 13, 2022 12:06

Wondertan added 3 commits January 13, 2022 14:14

changelog: add entry for #346

004d2e3

chore: fix lint issue

f62b945

node/p2p: remove network from Config

c498ce8

Wondertan mentioned this pull request Jan 13, 2022

node/services: use genesis if trusted hash is not set #348

Merged

Wondertan added 2 commits January 13, 2022 15:25

build: allow setting network with build time flags and use GetNetwork…

2b1d047

… where needed

build: add utilities to get genesis and bootstrapper of current network

0c57add

Wondertan force-pushed the hlib/build branch from b7a88e8 to 0c57add Compare January 13, 2022 13:26

feat(node/services): use genesis if trusted hash is not set

fd6fd73

renaynay requested changes Jan 13, 2022

View reviewed changes

Wondertan and others added 11 commits January 17, 2022 13:09

Update build/bootstrap.go

55c5e9b

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>

Update build/bootstrap.go

50fe542

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>

Update build/bootstrap.go

20985fa

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>

Update build/bootstrap.go

0397d78

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>

Update build/genesis.go

80c94f6

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>

Update build/genesis.go

b138cdb

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>

Update build/genesis.go

8e99c36

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>

Update build/networks.go

5275eaa

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>

Update build/networks.go

ede22b8

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>

Update build/networks.go

25a5538

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>

Update build/networks.go

cec022f

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>

renaynay self-requested a review January 20, 2022 11:09

Wondertan and others added 2 commits January 21, 2022 13:12

Update build/networks.go

97ae328

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>

Merge pull request #348 from celestiaorg/hlib/set-genesis

f05e0c2

fix(build) -> params

251a973

Wondertan changed the title ~~build: Define Network Types~~ params: Define Network Types Jan 21, 2022

liamsi reviewed Jan 22, 2022

View reviewed changes

node/p2p/p2p.go Outdated Show resolved Hide resolved

params/networks.go Show resolved Hide resolved

renaynay previously approved these changes Jan 23, 2022

View reviewed changes

CHANGELOG-PENDING.md Outdated Show resolved Hide resolved

Update node/p2p/p2p.go

b691913

Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>

Wondertan dismissed renaynay’s stale review via b691913 January 24, 2022 13:05

Update CHANGELOG-PENDING.md

c226369

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>

renaynay approved these changes Jan 24, 2022

View reviewed changes

liamsi approved these changes Jan 24, 2022

View reviewed changes

Wondertan merged commit 66cb969 into main Jan 24, 2022

Wondertan deleted the hlib/build branch January 24, 2022 18:47

distractedm1nd mentioned this pull request Sep 12, 2022

feat(cmd): Provide ability to specify network to user #1073

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

params: Define Network Types #346

params: Define Network Types #346

Wondertan commented Jan 13, 2022 •

edited

Wondertan commented Jan 21, 2022

Wondertan commented Jan 21, 2022

renaynay left a comment

params: Define Network Types #346

params: Define Network Types #346

Conversation

Wondertan commented Jan 13, 2022 • edited

Wondertan commented Jan 21, 2022

Wondertan commented Jan 21, 2022

renaynay left a comment

Choose a reason for hiding this comment

Wondertan commented Jan 13, 2022 •

edited