Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: TestRetrieveBlockData exceeds goroutine limit with -race flag #340

Closed
Bidon15 opened this issue Jan 11, 2022 · 4 comments
Closed

[Bug]: TestRetrieveBlockData exceeds goroutine limit with -race flag #340

Bidon15 opened this issue Jan 11, 2022 · 4 comments
Assignees
@vgonkivs
Labels
bug Something isn't working

Comments

@Bidon15
Copy link
Member

Bidon15 commented Jan 11, 2022

Celestia Node version

af0277b

OS

macOS 12.0.1

Install tools

No response

Others

No response

Steps to reproduce it

go test -v -race -run TestRetrieveBlockData ./ipld -count 1

Expected result

TestRetrieveBlockData is passing

Actual result

TestRetrieveBlockData is failing

Relevant log output

race: limit on 8128 simultaneously alive goroutines is exceeded, dying

Notes

Same is reproducible in github action execution
@Bidon15 Bidon15 added the bug Something isn't working label Jan 11, 2022
@Bidon15 Bidon15 mentioned this issue Jan 11, 2022
Merged
@Wondertan
Copy link
Member

It is not a race condition. Unfortunately, the race detector has a limit to the number of goroutines possible in the test and this test spawn goroutines deliberately.

@Wondertan Wondertan changed the title [Bug]: Race Condition in TestRetrieveBlockData [Bug]: TestRetrieveBlockData exceeds goroutine limit with -race flag Jan 12, 2022
This was referenced Jan 21, 2022
Merged
Merged
@Wondertan
Copy link
Member

The proper fix is: #247

@Wondertan
Copy link
Member

The test is now skipped with #388 and should be unskipped once the solution above is implemented.

@renaynay renaynay moved this to TODO in Celestia Node Feb 8, 2022
@renaynay renaynay moved this from TODO to In Review in Celestia Node Feb 18, 2022
@renaynay
Copy link
Member

Closing as #247 has been merged

Repository owner moved this from In Review to Done in Celestia Node Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vgonkivs vgonkivs

Labels
bug Something isn't working
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Bidon15 @Wondertan @vgonkivs @renaynay