core: package managing Core Node #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t with configuration
…work with HTTP by default
… implemntation; update tests accordingly
renaynay
reviewed
Sep 7, 2021
renaynay
reviewed
Sep 8, 2021
…estutils: move Core mock to core package
|
Note that the linter fails after some weird infrastructure reason. #53 |
renaynay
reviewed
Sep 9, 2021
renaynay
reviewed
Sep 9, 2021
renaynay
reviewed
Sep 9, 2021
renaynay
reviewed
Sep 9, 2021
renaynay
reviewed
Sep 9, 2021
renaynay
reviewed
Sep 9, 2021
renaynay
reviewed
Sep 9, 2021
renaynay
reviewed
Sep 9, 2021
renaynay
reviewed
Sep 9, 2021
|
Okay so decision here (as per #52 )is that we will offer both |
renaynay
reviewed
Sep 9, 2021
renaynay
reviewed
Sep 9, 2021
renaynay
reviewed
Sep 9, 2021
renaynay
reviewed
Sep 9, 2021
renaynay
reviewed
Sep 9, 2021
liamsi
reviewed
Sep 9, 2021
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
liamsi
reviewed
Sep 9, 2021
This was referenced Sep 13, 2021
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
* embed node add tests * clean up tests + rename * fix doc
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
renaynay
reviewed
Sep 13, 2021
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces a core package that mainly provides different Clients to work with Core Node. It introduces embeddable Core Node and keeps existing RPC clients. It also makes embedding Core a default behavior for Full Node with configurability to connect to remote Core if requested.
Closes #50