Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add tests for remote node #55

Merged
merged 3 commits into from
Sep 13, 2021

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Sep 10, 2021

This PR adds test for remote core node.

#51 depends on this PR.

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise looks good, thanks 👍🏻

core/client_test.go Outdated Show resolved Hide resolved
@liamsi
Copy link
Member

liamsi commented Sep 13, 2021

Do I understand this correctly and this should be merged before #51? Can you edit the opening comment to include any dependencies?

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional nit. You can merge it anyway

core/mock_test.go Show resolved Hide resolved
@renaynay renaynay merged commit 0e29403 into celestiaorg:hlib/embed-node Sep 13, 2021
@renaynay renaynay deleted the embed-node-tests branch September 13, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node: embed Core node process into Full node
3 participants