-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: use either Hardfork or Network upgrade consistently across docs #1676
Comments
Relevant:
TLDR: there isn't team alignment on the decision to use "hard fork" or "network upgrade" so we need to build alignment before we implement this. |
Thank you for adding the context! Yep, acknowledging that we'll need to align here first. |
Voting on poll is leaning toward "Network upgrade" 14-1 https://celestia-team.slack.com/archives/C01JZFUPG48/p1724260139073369 |
I'm in favor of network upgrade. When we address this issue, we should try to avoid breaking existing links to the docs. Or if we break the links, we should try to fix them. For example the v2.0.0 release notes link to Lemongrass hardfork. |
Good call out. Do you think it would be best practice to leave "Lemongrass hardfork" as is? So as to not break things for that, and going forward, use Network upgrade? |
I'm fine with renaming "Lemongrass hardfork" => "Lemongrass network upgrade" if we add a redirect or fix links |
While it is possible, it still feels a little jank, because you have to leave an old page up still. This is the cleanest way in Vitepress to do redirects that I know of: https://github.com/celestiaorg/docs/pull/1542/files |
I just tried two alternative way to configure redirects:
but neither worked so agreed that it's kinda jank |
I plan to implement this after v2 is live this week |
can you please update the link on v2.0.0 release notes to "https://docs.celestia.org/nodes/hardfork-process#lemongrass-network-upgrade"? |
To clear confusion, use either Hardfork or Network upgrade consistently throughout the documentation. This is also related to #1675.
The text was updated successfully, but these errors were encountered: