Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added second parameter to SupervisionGroup.pool method to pass options hash #71

Merged
merged 1 commit into from
Aug 15, 2012

Conversation

bsingr
Copy link
Contributor

@bsingr bsingr commented Aug 15, 2012

Now you can do something like the following:

class MyGroup < Celluloid::SupervisionGroup
  pool Worker, as: :worker_pool
end

Without this patch the same can be done using the following:

class MyGroup < Celluloid::SupervisionGroup
  supervise Worker, as: :worker_pool, method: 'pool_link'
end

…s hash (e.g. the :as option to register the pool in the Celluloid::Actor[] directory).
tarcieri added a commit that referenced this pull request Aug 15, 2012
Added second parameter to SupervisionGroup.pool method to pass options hash
@tarcieri tarcieri merged commit 703f79b into celluloid:master Aug 15, 2012
@tarcieri
Copy link
Member

Thanks!

@travisbot
Copy link

This pull request fails (merged 5b711e8 into b58b34e).

tarcieri added a commit that referenced this pull request Nov 29, 2014
Never shovel nil so you don't have to compact
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants