Validate debitGasFees execution in tx pool #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage from tests in coverage: 51.2% of statements across all listed packagescoverage: 63.2% of statements in consensus/istanbul coverage: 43.2% of statements in consensus/istanbul/announce coverage: 56.0% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 65.9% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.2% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
|
karlb
force-pushed
the
karlb/check-debit-in-tx-pool
branch
from
2cbd161
to
8b1b5f2
Compare
palango
reviewed
Mar 4, 2024
karlb
force-pushed
the
karlb/check-debit-in-tx-pool
branch
from
8b1b5f2
to
ac78803
Compare
We need this somewhat unusual function to check if `debitGasFees` can be successfully executed without keeping the resulting state changes.
Txs must not fail during debitGasFees execution during the state transition, so we must remove problematic txs during the tx pool validation.
karlb
force-pushed
the
karlb/check-debit-in-tx-pool
branch
from
ac78803
to
5f587ca
Compare
The pre-espresso case it not used anymore and can be safely removed.
karlb
force-pushed
the
karlb/check-debit-in-tx-pool
branch
from
5f587ca
to
cb74c28
Compare
piersy
reviewed
Mar 5, 2024
core/tx_pool.go
Outdated
| cost := new(big.Int).SetUint64(tx.Gas()) | ||
| cost.Mul(cost, tx.GasFeeCap()) | ||
| cost.Add(cost, tx.Value()) | ||
| if tx.GatewayFeeRecipient() != nil { |
There was a problem hiding this comment.
Wasn't support for gateway fees removed in gingerbread, could this be cleaned up as well?
There was a problem hiding this comment.
Yes, and I could also remove the "(2)" comment, since only once case is left.
piersy
reviewed
Mar 5, 2024
| return ErrInsufficientFunds | ||
| } | ||
| } | ||
| return erc20gas.TryDebitFees(tx, from, currentVMRunner) |
There was a problem hiding this comment.
Rather than having an else statement we could simplify this function like this:
if tx.FeeCurrency() != nil {
return erc20gas.TryDebitFees(tx, from, currentVMRunner)
}
...
We don't need to support the pre-gingerbread behaviour of the tx pool anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Txs must not fail during
debitGasFeesexecution during the state transition, so we must remove problematic txs during the tx pool validation. We do this by executingdebitGasFeesinside the tx pool validation and discarding the resulting state changes. This is not overly efficient, but still better than the alternatives that have been considered so far.Other changes
ExecuteAndDiscardChangestovm.EVMRunner. I would have liked to avoid this change, butStaticCalldoes not allow (even temporary) changes and I didn't see a better way.debitGasFeesSelectorandcreditGasFeesSelectorand updated comment to show how to generate the selector withcastinstead of python.debitGasFeesand I want to avoid duplicate workValidateTransactorBalanceCoversTx, since we don't need to support older forks in the tx poolTested
Manually by sending txs via Viem to a local mycelo. Adding a unit test would be desirable.
I'm haven't tested that the state revert works as expected and am also not sure about the performance impact.
Backwards compatibility
At the time of writing, we don't have any fee currencies on mainnet that can fail in
debitGasFees. The error message for fee currencies without sufficient balance will change with this PR. The new error will contain the revert message from the token'sdebitGasFees.