Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate debitGasFees execution in tx pool #2279

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Validate debitGasFees execution in tx pool #2279

merged 6 commits into from
Mar 12, 2024

Commits on Mar 5, 2024

  1. Add VMRunner.ExecuteAndDiscardChanges 

    We need this somewhat unusual function to check if `debitGasFees` can be
successfully executed without keeping the resulting state changes.
    @karlb
    karlb committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    8beed18 View commit details
    Browse the repository at this point in the history

  2. Validate debitGasFees execution in tx pool 

    Txs must not fail during debitGasFees execution during the state
transition, so we must remove problematic txs during the tx pool
validation.
    @karlb
    karlb committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    5c8713c View commit details
    Browse the repository at this point in the history

  3. tx_pool cleanup: remove pre-espresso case 

    The pre-espresso case it not used anymore and can be safely removed.
    @karlb
    karlb committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    cb74c28 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Remove gatewayFee from ValidateTransactorBalanceCoversTx

    @karlb
    karlb committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    39047b8 View commit details
    Browse the repository at this point in the history

  2. refactor: return early in ValidateTransactorBalanceCoversTx

    @karlb
    karlb committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    8890102 View commit details
    Browse the repository at this point in the history

  3. Remove pre-gingerbread tx pool test 

    We don't need to support the pre-gingerbread behaviour of the tx pool
anymore.
    @karlb
    karlb committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    5762f68 View commit details
    Browse the repository at this point in the history