Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Fix crash on Android release builds #5960

Merged
merged 3 commits into from
Nov 26, 2020

Conversation

jeanregisser
Copy link
Contributor

Description

Update pro-guard rules to fix a crash at startup for release builds.

See segmentio/analytics-android#732

Other changes

None.

Tested

Release build doesn't crash at startup.

Related issues

Backwards compatibility

Yes

@jeanregisser jeanregisser requested a review from a team November 26, 2020 09:45
@jeanregisser jeanregisser changed the title [Wallet] Fix crash on release builds [Wallet] Fix crash on Android release builds Nov 26, 2020
Copy link
Contributor

@i1skn i1skn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeanregisser jeanregisser added automerge Have PR merge automatically when checks pass wallet labels Nov 26, 2020
@mergify mergify bot merged commit 67220f4 into master Nov 26, 2020
@mergify mergify bot deleted the jeanregisser/fix-segment-crash branch November 26, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App get crash while opening after install
2 participants