Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read functions should throw error for unknown engine #343

Open
tlukkezen opened this issue Jul 26, 2023 · 0 comments
Open

read functions should throw error for unknown engine #343

tlukkezen opened this issue Jul 26, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@tlukkezen
Copy link
Collaborator

When the value of the engine argument for the read_cpt and read_bore functions is not recognized, the default value is used.

Example to reproduce

Input:

from pygef import read_cpt
read_cpt(file="non/existing/file.gef", engine="non-existing-engine")

Response:

lxml.etree.XMLSyntaxError: Start tag expected, '<' not found, line 1, column 1

Expectation

The expectation is to get an informative error about the enigne value.

@tlukkezen tlukkezen added the bug Something isn't working label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant