Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Dark Mode #120

Open
BParks21 opened this issue Aug 30, 2022 · 16 comments
Open

[Feature Request] Dark Mode #120

BParks21 opened this issue Aug 30, 2022 · 16 comments
Labels
feature request New feature or request

Comments

@BParks21
Copy link

Probably the only emulator I use without some type of dark mode. Idk if it's possible based on the ui software cemu uses but it would be greatly appreciated!

@qurious-pixel
Copy link
Contributor

qurious-pixel commented Aug 30, 2022

image

GTK_THEME="Adwaita:dark" ./Cemu

@cabrerahector
Copy link

cabrerahector commented Aug 30, 2022

Cemu uses wxWidgets for the user interface. AFAIK it's wxWidgets that needs to provide a Dark Mode UI so might want to try asking (nicely) wxWidgets devs about it (but chances are they have already received this request from other people by now).

TLDR;

Cemu depends on wxWidgets devs to implement this functionality.

@BParks21
Copy link
Author

I don't feel like I was asking impolitely I apologize if it seemed that way.

@cabrerahector
Copy link

Don't sweat it, I didn't say that you were being impolite here or anything :P

@Squall-Leonhart
Copy link
Contributor

WxWidgets uses Win32 for theming, which doesn't itself have dark mode toggle support, so the entire thing must be manually changed

it does support windows 10's high contrast black mode though.

@Crementif
Copy link
Member

Crementif commented Aug 30, 2022

According to https://www.windowslatest.com/2022/06/02/windows-11-22h2-is-bringing-mica-acrylic-design-to-more-win32-desktop-apps/ might make it easier for win32 applications to also use the dark mode elements they added for windows explorer. But we'll need to wait till that's out and devs are running it. 🤞

@Crementif Crementif added the feature request New feature or request label Aug 30, 2022
@Squall-Leonhart
Copy link
Contributor

There is this... https://github.com/ysc3839/win32-darkmode

@OEMunlag
Copy link

OEMunlag commented Aug 31, 2022

WxWidgets uses Win32 for theming, which doesn't itself have dark mode toggle support, so the entire thing must be manually changed

it does support windows 10's high contrast black mode though.

That's where msstyles come in hand, msstyles are the microsoft themes/styles that you could use to modify those themes, so Win32 normally uses those msstyles, the main fault being ms being lazy and not fixing their msstyles which means they are still not fully dark, you could patch uxtheme and get a custom msstyles and get nice results

Here is a custom dark msstyles which somehow seems to work.
image

And the graphics packs tab using MicaForEveryone with the Tabbed (basically a more contrasty Mica)
image

My main point:
things like WxWidgets which depend on msstyles, need ms to change the msstyles, so the problem isn't heavily on WxWidgets, but more on the ms crappy msstyles.

@Masamune3210
Copy link

Its still a wxWidgets issue, Themes on Windows will color anything that reports supporting theming, so just because a custom theme fixes the issue somewhat doesn't pass the blame from wxWidgets to Microsoft.

@n0toose
Copy link
Contributor

n0toose commented Sep 1, 2022

WxWidgets uses Win32 for theming, which doesn't itself have dark mode toggle support

Some concepts for that in a similar project that also uses wxWidgets can be found here: https://github.com/tenacityteam/tenacity/pull/608

@Exzap
Copy link
Member

Exzap commented Sep 30, 2023

The upcoming wxWidgets 3.3.0 release has the beginnings of dark mode support for Windows. I hacked together a test using their development branch and here is what it currently looks like:
image
Considering this is how it appears out of the box without any fine-tuning I would say it looks pretty decent.

They don't have an ETA for when 3.3.0 is officially out, but it's probably going to be a couple of months.

@BParks21
Copy link
Author

BParks21 commented Oct 1, 2023

Can't wait!

@Nihilhem
Copy link

Nice! I'd been waiting for so long for Cemu to have a Dark Mode, that I thought it would never happen. But seeing that it may be within a year from now is very satisfying!

@chasio2221
Copy link

follow up?

@Exzap
Copy link
Member

Exzap commented Sep 3, 2024

No news. wxWidgets 3.3.0 is not out yet

@RobbyCBennett
Copy link

Here's a way to approximate when wxWidgets 3.3.0 will release: https://github.com/wxWidgets/wxWidgets/milestone/14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests