passing callback url to authorize

[rochacbruno]

Hi, in the docs there is:

def authorized_handler(self, f):
        """
        Decorator for the route that is used as the callback for authorizing
        with GitHub. This callback URL can be set in the settings for the app
        or passed in during authorization.

        """

https://github.com/cenkalti/github-flask/blob/master/flask_github.py#L98

But there is no such parameter in authorize

def authorize(self, scope=None):
        """
        Redirect to GitHub and request access to a user's data.

        """

https://github.com/cenkalti/github-flask/blob/master/flask_github.py#L77

How can I pass the callback url during the authorization?

[cenkalti]

I guess the documentation is wrong. The callback_url can only be set in the app settings.
Anyway, why do you want to set it during authorization?

[rochacbruno]

I need to pass a myurl/callback/?next=/another/path

[cenkalti]

I have made the change: 6e12328

I haven't tested it yet but it should work. Make sure that you are passing a valid URL:
https://developer.github.com/v3/oauth/#redirect-urls

[cenkalti]

Did it work? If yes, I will push a new version to PyPI.

[HelloGrayson]

no tests :(

[cenkalti]

In my opinion this is a small change that does not need testing. Please re-open if not working.

[cenkalti]

I have added redirect_uri parameter to tests. 038be00