Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorectly decompile *.rpyc files from Ren'py v6.99.14.1 game #70

Closed
hubslave opened this issue Mar 7, 2018 · 3 comments
Closed

Incorectly decompile *.rpyc files from Ren'py v6.99.14.1 game #70

hubslave opened this issue Mar 7, 2018 · 3 comments

Comments

@hubslave
Copy link

hubslave commented Mar 7, 2018

Hear is a sample: http://www107.zippyshare.com/v/lQeTHGEP/file.html
Only some of the files have the problem, take a look at the files in \game\characters\

@CensoredUsername
Copy link
Owner

Based on some preliminary analysis, this game mods the ren'py engine quite heavily by introducing a new AST node in it's early script files, without using the normal API for those (renpy.register_statement). This makes it impossible to decompile this game without making changes to the decompiler so it knows how to deal with this statement. Furthermore the implementation is rather dirty causing RevertableList instances to show up in the script AST which I've never seen before and which were causing the fatal errors rather than a "could not decompile node" comment.

I can push the necessary patches to at least parse the files correctly to a separate branch, but reversing how their custom ASTs work is a lot of work that will be only applicable to this specific game so I'm not too interested in it.

@CensoredUsername
Copy link
Owner

I've pushed the necessary changes to not make decompilation fail completely to the innocent_witches branch. However a significant amount of work is still necessary to fully decompile the scripts due to the ast modding.

@Andykl
Copy link

Andykl commented Jun 27, 2018

Thank you for pointing out this mistake.
I moved the CallLocation class to the python file.
Unfortunately UserStatement makes it impossible to use ast.next_node and predict renpy code block.
It would be nice to make the function of decompiling third-party ast classes, I think I'll add a couple more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants