Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Build is broken #675

Closed
rakyll opened this issue Apr 5, 2018 · 2 comments
Closed

Build is broken #675

rakyll opened this issue Apr 5, 2018 · 2 comments

Comments

@rakyll
Copy link
Contributor

rakyll commented Apr 5, 2018

Build is broken due to the broken Thrift import paths, see https://issues.apache.org/jira/browse/THRIFT-4542.

This is affecting us due to the Jaeger and Zipkin exporters.

rakyll added a commit to rakyll/opencensus-go that referenced this issue Apr 5, 2018
rakyll added a commit that referenced this issue Apr 5, 2018
@johanbrandhorst
Copy link
Contributor

This still doesn't fix the case for users of golang/dep which will still attempt to clone the old repo. I think we should reopen this issue or open a new tracking issue for migrating to the new import path.

@johanbrandhorst
Copy link
Contributor

johanbrandhorst commented Apr 6, 2018

For dep users, the following will work (modify versions as necessary):

[[constraint]]
  branch = "master"
  name = "go.opencensus.io"

[[override]]
  branch = "master"
  name = "git.apache.org/thrift.git"
  source = "github.com/apache/thrift"

rakyll added a commit to rakyll/opencensus-go that referenced this issue Apr 6, 2018
@rakyll rakyll mentioned this issue Apr 6, 2018
rakyll added a commit that referenced this issue Apr 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants