Add explicit library dependencies #703
Conversation
|
We'll probably want to discuss some procedure for updating dependencies as well, for example gRPC-Go has a (afaik) 3 monthly release cycle and we'll certainly want to stick to that. This may already be in place. |
There was a problem hiding this comment.
I propose we use major version ranges wherever possible in Gopkg.toml (version = "^1.X.Y"). Hopefully this works for everything except thrift.
@rakyll what do you think?
|
|
||
| [[constraint]] | ||
| name = "google.golang.org/grpc" | ||
| version = "1.11.3" |
There was a problem hiding this comment.
I think we should default to specifying major version ranges for everything, so: version = "^1.11.3" here
There was a problem hiding this comment.
This is equivalent to ^1.11.3 https://golang.github.io/dep/docs/Gopkg.toml.html#version.
There was a problem hiding this comment.
ah missed that, thanks :)
|
I think we need to be able to test this. What do you think of the following changes?:
That will make sure we are testing with the versions specified here but avoid vendoring the code. |
johanbrandhorst
force-pushed
the
add-explicit-library-dependencies
branch
3 times, most recently
from
c15f75d
to
c8f394d
Compare
Adds Gopkg.toml and Gopkg.lock with initial dependency versions. Includes workaround for Apache Thrift repo migration. Ignores the vendor folder and adds a travis test to ensure dependency version updates don't break the build. Fixes census-instrumentation#684.
johanbrandhorst
force-pushed
the
add-explicit-library-dependencies
branch
from
c8f394d
to
cede0dd
Compare
|
Please re-review with the changes suggested. |
|
When will this be in a release? |
|
/cc @Ramonza, can we cut a new release? |
|
Let's do a release after #728 |
Fixes #684.
Adds Gopkg.toml and Gopkg.lock with initial dependency versions. Includes workaround for Apache Thrift repo migration.
The versions used were chosen by
dep init, and I welcome a discussion about exactly which direct dependency versions we want to use. The currently chosen versions allow all packages to build successfully so are a good starting point.